Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 10.80%. Comparing base (d0f63c0) to head (d414170).

@@             Coverage Diff              @@
##               main    #4477      +/-   ##
============================================
- Coverage     11.00%   10.80%   -0.20%     
  Complexity      265      265              
============================================
  Files           122      122              
  Lines          5608     5708     +100     
  Branches       1215     1246      +31     
============================================
  Hits            617      617              
- Misses         4869     4969     +100     
  Partials        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I found this bug
clicking on the icon clicking on the components
https://github.com/user-attachments/assets/653755d1-ee75-4395-aac6-5f73c2b9375a https://github.com/user-attachments/assets/17c95786-5a70-4258-ab41-9460687ad746

Hey! are you sure that's the right video @hamza221 😅?

Either way, yes clicking on the avatar has a different action, like in mail. Is it not working intuitively?

Hey! are you sure that's the right video @hamza221 😅?

Mb I uploaded the wrong video, please have another look I updated it

Either way, yes clicking on the avatar has a different action, like in mail. Is it not working intuitively?

IMO selection should either work the same way when clicking on the component and Avatar, or not work at all when clicking the component.
Also Shift+ click is usually inclusive of the last element pressed.

Notes from meeting:

• Only show actions if at least one contact supports that action

Advice from Nimisha:

• Make the check a little smaller
• Add a short animation when showing the actions

EDIT: done

@nimishavijay Here's the checkboxes becoming a little smaller, delete being grayed out because it can't be applied, and on hover it says "Please select at least one editable contact to delete".

I also added the same animation as in mail but quicker.

The above mentioned bug is still unresolved https://github.com/user-attachments/assets/b2e6a3e9-fc45-4c9e-93f3-45d9058986fc

Edit: Mail app for comparison
Screen.Recording.2025-06-20.at.18.22.19.mov

Ahn I see, fixed now, thanks!

Nice! Looks great with the smaller checkmarks now.

Only change would be in the confirmation dialog. We can use an NcNoteCard component in the warning style to show the read only warning, that should make it more eye-catching :)

Good idea!

Here's how I made it look now